Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[nrfconnect] Include GenericSwitch in light-switch example #19848

Merged
merged 16 commits into from
Jun 24, 2022
Merged

[nrfconnect] Include GenericSwitch in light-switch example #19848

merged 16 commits into from
Jun 24, 2022

Conversation

markus-becker-tridonic-com
Copy link
Contributor

Problem

In matter there are 2 types of light switch device types:

  • On/Off Light Switch, Dimmer Switch, Color Dimmer Switch, Control Bridge
  • Generic Switch

Up to now only the first type was shown in the light-switch example.

Change overview

This PR adds GenericSwitch for the nrfconnect light-switch sample.

The GenericSwitch has been added on EP 2 and uses button 3.

The code implements a momentary switch with features MS and MSR.

Testing

Tested using chip-tool and DK:

    chip-tool interactive start

Subscribe to the initial-press and short-release

    >>> switch subscribe-event initial-press 1 20 <node_id> 2 --is-urgent true
    >>> switch subscribe-event initial-press 1 20 <node_id> 2 --is-urgent true

@restyled-io restyled-io bot mentioned this pull request Jun 22, 2022
Closed
@restyled-io restyled-io bot mentioned this pull request Jun 23, 2022
Closed
@markus-becker-tridonic-com
Add missed generated file.
a7a07ae
@restyled-commits @markus-becker-tridonic-com
Restyled by prettier-markdown
f34b912
@markus-becker-tridonic-com
Adress review comments
5fb8316 
* Directly calling GenericSwitchInitialPress/GenericSwitchReleasePress without Timer
* Rename newPosition/previousPosition
@markus-becker-tridonic-com
Update zap
aa3b6ee 
* Remove Switch cluster on EP0
* Disabled Groups, Scenes, Binding on EP2
* Named EP2
@markus-becker-tridonic-com
Correct previousPosition and newPosition.
07b5884
@markus-becker-tridonic-com @greg-fer
Apply suggestions from code review
cd1b9e1 
Thanks @greg-fer.

Co-authored-by: Grzegorz Ferenc <41291385+greg-fer@users.noreply.github.com>
@github-actions
Copy link

github-actions bot commented Jun 23, 2022 •
edited
Loading

PR #19848: Size comparison from 29451fb to e039af7

Increases (5 builds for cc13x2_26x2, cyw30739, nrfconnect, telink)
platform target config section 29451fb e039af7 change % change
cc13x2_26x2 lock-ftd LP_CC2652R7 (read/write) 149620 149628 8 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 591738 591746 8 0.0
.app_xip_area 462636 462644 8 0.0
nrfconnect lock-app nrf52840dk_nrf52840 (read/write) 1114503 1114519 16 0.0
text 761448 761452 4 0.0
telink light-switch-app tlsr9518adk80d (read/write) 792208 792564 356 0.0
bss 71140 71168 28 0.0
text 561074 561098 24 0.0
lighting-app tlsr9518adk80d text 577532 577534 2 0.0
Decreases (4 builds for cc13x2_26x2, nrfconnect)
platform target config section 29451fb e039af7 change % change
cc13x2_26x2 all-clusters-minimal-app LP_CC2652R7 (read only) 649351 649343 -8 -0.0
.text 558408 558400 -8 -0.0
lock-ftd LP_CC2652R7 (read only) 692099 692091 -8 -0.0
.text 592148 592140 -8 -0.0
nrfconnect all-clusters-minimal-app nrf52840dk_nrf52840 text 796020 796016 -4 -0.0
lighting-app nrf52840dk_nrf52840 (read/write) 1161535 1161519 -16 -0.0
text 815060 815056 -4 -0.0
Full report (44 builds for cc13x2_26x2, cyw30739, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section 29451fb e039af7 change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 660451 660451 0 0.0
(read/write) 191156 191156 0 0.0
.bss 74500 74500 0 0.0
.data 3356 3356 0 0.0
.rodata 87011 87011 0 0.0
.text 573128 573128 0 0.0
all-clusters-minimal-app LP_CC2652R7 (read only) 649351 649343 -8 -0.0
(read/write) 158060 158060 0 0.0
.bss 73788 73788 0 0.0
.data 3356 3356 0 0.0
.rodata 90623 90623 0 0.0
.text 558408 558400 -8 -0.0
lock-ftd LP_CC2652R7 (read only) 692099 692091 -8 -0.0
(read/write) 149620 149628 8 0.0
.bss 71500 71500 0 0.0
.data 3280 3280 0 0.0
.rodata 99467 99467 0 0.0
.text 592148 592140 -8 -0.0
lock-mtd LP_CC2652R7 (read only) 641515 641515 0 0.0
(read/write) 144632 144632 0 0.0
.bss 67236 67236 0 0.0
.data 3280 3280 0 0.0
.rodata 99355 99355 0 0.0
.text 541668 541668 0 0.0
pump-app LP_CC2652R7 (read only) 673335 673335 0 0.0
(read/write) 169280 169280 0 0.0
.bss 71628 71628 0 0.0
.data 3280 3280 0 0.0
.rodata 87783 87783 0 0.0
.text 585068 585068 0 0.0
pump-controller-app LP_CC2652R7 (read only) 659223 659223 0 0.0
(read/write) 183504 183504 0 0.0
.bss 71740 71740 0 0.0
.data 3276 3276 0 0.0
.rodata 83623 83623 0 0.0
.text 575120 575120 0 0.0
shell LP_CC2652R7 (read only) 690290 690290 0 0.0
(read/write) 156820 156820 0 0.0
.bss 76804 76804 0 0.0
.data 3360 3360 0 0.0
.rodata 109866 109866 0 0.0
.text 580112 580112 0 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 591738 591746 8 0.0
.app_xip_area 462636 462644 8 0.0
.bss 72064 72064 0 0.0
.data 716 716 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
lock cyw930739m2evb_01 (read/write) 589130 589130 0 0.0
.app_xip_area 459852 459852 0 0.0
.bss 72240 72240 0 0.0
.data 720 720 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 594262 594262 0 0.0
.app_xip_area 466032 466032 0 0.0
.bss 71248 71248 0 0.0
.data 660 660 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
esp32 all-clusters-app c3devkit (read only) 1014134 1014134 0 0.0
(read/write) 1484882 1484882 0 0.0
.dram0.bss 70640 70640 0 0.0
.dram0.data 14632 14632 0 0.0
.flash.rodata 214176 214176 0 0.0
.flash.text 1014134 1014134 0 0.0
.iram0.text 62902 62902 0 0.0
m5stack (read only) 1068475 1068475 0 0.0
(read/write) 486968 486968 0 0.0
.dram0.bss 76152 76152 0 0.0
.dram0.data 34144 34144 0 0.0
.flash.rodata 244676 244676 0 0.0
.flash.text 1063091 1063091 0 0.0
.iram0.text 123267 123267 0 0.0
k32w light k32w061+release (read/write) 661564 661564 0 0.0
.bss 69756 69756 0 0.0
.data 1992 1992 0 0.0
.text 584016 584016 0 0.0
lock k32w061+release (read/write) 723544 723544 0 0.0
.bss 70204 70204 0 0.0
.data 2000 2000 0 0.0
.text 645540 645540 0 0.0
linux all-clusters-app debug (read only) 2939145 2939145 0 0.0
(read/write) 177136 177136 0 0.0
.bss 84192 84192 0 0.0
.data 2048 2048 0 0.0
.data.rel.ro 84696 84696 0 0.0
.dynamic 608 608 0 0.0
.got 4536 4536 0 0.0
.init 27 27 0 0.0
.init_array 1032 1032 0 0.0
.rodata 261661 261661 0 0.0
.text 2500994 2500994 0 0.0
all-clusters-minimal-app debug (read only) 2792921 2792921 0 0.0
(read/write) 169040 169040 0 0.0
.bss 83520 83520 0 0.0
.data 2048 2048 0 0.0
.data.rel.ro 77336 77336 0 0.0
.dynamic 608 608 0 0.0
.got 4488 4488 0 0.0
.init 27 27 0 0.0
.init_array 1032 1032 0 0.0
.rodata 263261 263261 0 0.0
.text 2355346 2355346 0 0.0
bridge-app debug+rpc (read only) 2296905 2296905 0 0.0
(read/write) 147936 147936 0 0.0
.bss 71616 71616 0 0.0
.data 3792 3792 0 0.0
.data.rel.ro 66760 66760 0 0.0
.dynamic 608 608 0 0.0
.got 4400 4400 0 0.0
.init 27 27 0 0.0
.init_array 728 728 0 0.0
.rodata 196448 196448 0 0.0
.text 1939202 1939202 0 0.0
chip-tool debug (read only) 10165629 10165629 0 0.0
(read/write) 610600 610600 0 0.0
.bss 24416 24416 0 0.0
.data 1088 1088 0 0.0
.data.rel.ro 578792 578792 0 0.0
.dynamic 624 624 0 0.0
.got 5008 5008 0 0.0
.init 27 27 0 0.0
.init_array 640 640 0 0.0
.rodata 508629 508629 0 0.0
.text 8249013 8249013 0 0.0
chip-tool-no-interactive-ipv6only arm64 (read only) 9902644 9902644 0 0.0
(read/write) 675265 675265 0 0.0
.bss 42641 42641 0 0.0
.data 1152 1152 0 0.0
.data.rel.ro 614184 614184 0 0.0
.dynamic 528 528 0 0.0
.got 13472 13472 0 0.0
.init 24 24 0 0.0
.init_array 192 192 0 0.0
.rodata 471492 471492 0 0.0
.text 7892292 7892292 0 0.0
lighting-app debug+rpc (read only) 2533673 2533673 0 0.0
(read/write) 151928 151928 0 0.0
.bss 72064 72064 0 0.0
.data 2064 2064 0 0.0
.data.rel.ro 71912 71912 0 0.0
.dynamic 608 608 0 0.0
.got 4432 4432 0 0.0
.init 27 27 0 0.0
.init_array 816 816 0 0.0
.rodata 212200 212200 0 0.0
.text 2151634 2151634 0 0.0
lock-app debug (read only) 2466977 2466977 0 0.0
(read/write) 146672 146672 0 0.0
.bss 70496 70496 0 0.0
.data 1680 1680 0 0.0
.data.rel.ro 68632 68632 0 0.0
.dynamic 608 608 0 0.0
.got 4432 4432 0 0.0
.init 27 27 0 0.0
.init_array 776 776 0 0.0
.rodata 225928 225928 0 0.0
.text 2076610 2076610 0 0.0
ota-provider-app debug (read only) 2304817 2304817 0 0.0
(read/write) 140776 140776 0 0.0
.bss 70176 70176 0 0.0
.data 1912 1912 0 0.0
.data.rel.ro 62872 62872 0 0.0
.dynamic 608 608 0 0.0
.got 4496 4496 0 0.0
.init 27 27 0 0.0
.init_array 672 672 0 0.0
.rodata 202104 202104 0 0.0
.text 1940418 1940418 0 0.0
ota-requestor-app debug (read only) 2421921 2421921 0 0.0
(read/write) 147648 147648 0 0.0
.bss 72544 72544 0 0.0
.data 2200 2200 0 0.0
.data.rel.ro 67048 67048 0 0.0
.dynamic 608 608 0 0.0
.got 4488 4488 0 0.0
.init 27 27 0 0.0
.init_array 728 728 0 0.0
.rodata 205984 205984 0 0.0
.text 2045266 2045266 0 0.0
shell debug (read only) 2612633 2612633 0 0.0
(read/write) 196120 196120 0 0.0
.bss 111304 111304 0 0.0
.data 1232 1232 0 0.0
.data.rel.ro 77832 77832 0 0.0
.dynamic 608 608 0 0.0
.got 4168 4168 0 0.0
.init 27 27 0 0.0
.init_array 936 936 0 0.0
.rodata 231698 231698 0 0.0
.text 2221154 2221154 0 0.0
thermostat-no-ble arm64 (read only) 2579044 2579044 0 0.0
(read/write) 180673 180673 0 0.0
.bss 87905 87905 0 0.0
.data 1704 1704 0 0.0
.data.rel.ro 82952 82952 0 0.0
.dynamic 528 528 0 0.0
.got 5088 5088 0 0.0
.init 24 24 0 0.0
.init_array 400 400 0 0.0
.rodata 164724 164724 0 0.0
.text 2175104 2175104 0 0.0
tv-app debug (read only) 3079665 3079665 0 0.0
(read/write) 277864 277864 0 0.0
.bss 187720 187720 0 0.0
.data 4656 4656 0 0.0
.data.rel.ro 79048 79048 0 0.0
.dynamic 608 608 0 0.0
.got 4840 4840 0 0.0
.init 27 27 0 0.0
.init_array 952 952 0 0.0
.rodata 247808 247808 0 0.0
.text 2644946 2644946 0 0.0
tv-casting-app debug (read only) 5542289 5542289 0 0.0
(read/write) 184144 184144 0 0.0
.bss 72872 72872 0 0.0
.data 2448 2448 0 0.0
.data.rel.ro 102592 102592 0 0.0
.dynamic 608 608 0 0.0
.got 4712 4712 0 0.0
.init 27 27 0 0.0
.init_array 864 864 0 0.0
.rodata 341737 341737 0 0.0
.text 4924274 4924274 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2439536 2439536 0 0.0
.bss 212180 212180 0 0.0
.data 5864 5864 0 0.0
.text 1402180 1402180 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1202387 1202387 0 0.0
bss 142862 142862 0 0.0
rodata 156372 156372 0 0.0
text 824228 824228 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1149735 1149735 0 0.0
bss 142098 142098 0 0.0
rodata 132704 132704 0 0.0
text 796020 796016 -4 -0.0
lighting-app nrf52840dk_nrf52840 (read/write) 1161535 1161519 -16 -0.0
bss 144441 144441 0 0.0
rodata 123160 123160 0 0.0
text 815060 815056 -4 -0.0
nrf52840dk_nrf52840+rpc (read/write) 1131607 1131607 0 0.0
bss 144886 144886 0 0.0
rodata 114704 114704 0 0.0
text 792788 792788 0 0.0
nrf52840dongle_nrf52840 (read/write) 1068387 1068387 0 0.0
bss 151672 151672 0 0.0
rodata 92236 92236 0 0.0
text 743460 743460 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 1065210 1065210 0 0.0
bss 140812 140812 0 0.0
rodata 115568 115568 0 0.0
text 727780 727780 0 0.0
lock-app nrf52840dk_nrf52840 (read/write) 1114503 1114519 16 0.0
bss 134390 134390 0 0.0
rodata 139912 139912 0 0.0
text 761448 761452 4 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 1018510 1018510 0 0.0
bss 130793 130793 0 0.0
rodata 132380 132380 0 0.0
text 674236 674236 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 1074487 1074487 0 0.0
bss 134336 134336 0 0.0
rodata 116544 116544 0 0.0
text 744764 744764 0 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 1062403 1062403 0 0.0
bss 134131 134131 0 0.0
rodata 113324 113324 0 0.0
text 736148 736148 0 0.0
p6 all-clusters-app default (read/write) 2555936 2555936 0 0.0
.bss 147360 147360 0 0.0
.data 2776 2776 0 0.0
.text 1514200 1514200 0 0.0
all-clusters-minimal-app default (read/write) 2501800 2501800 0 0.0
.bss 146640 146640 0 0.0
.data 2776 2776 0 0.0
.text 1460064 1460064 0 0.0
light-app default (read/write) 2432536 2432536 0 0.0
.bss 138720 138720 0 0.0
.data 2592 2592 0 0.0
.text 1390800 1390800 0 0.0
lock-app default (read/write) 2453264 2453264 0 0.0
.bss 138544 138544 0 0.0
.data 2600 2600 0 0.0
.text 1411528 1411528 0 0.0
telink light-switch-app tlsr9518adk80d (read/write) 792208 792564 356 0.0
bss 71140 71168 28 0.0
noinit 40416 40416 0 0.0
text 561074 561098 24 0.0
lighting-app tlsr9518adk80d (read/write) 811912 811912 0 0.0
bss 71388 71388 0 0.0
noinit 40416 40416 0 0.0
text 577532 577534 2 0.0

@greg-fer
Copy link
Contributor

Thanks for applying the edits, @markus-becker-tridonic-com !

@github-actions
Copy link

github-actions bot commented Jun 23, 2022 •
edited
Loading

PR #19848: Size comparison from 29451fb to c4b4ca0

Increases above 0.2%:

platform target config section 29451fb c4b4ca0 change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 .bss 74500 74964 464 0.6
all-clusters-minimal-app LP_CC2652R7 (read/write) 158060 158524 464 0.3
.bss 73788 74252 464 0.6
lock-ftd LP_CC2652R7 (read/write) 149620 150092 472 0.3
.bss 71500 71964 464 0.6
lock-mtd LP_CC2652R7 (read/write) 144632 145096 464 0.3
.bss 67236 67700 464 0.7
pump-app LP_CC2652R7 (read/write) 169280 169736 456 0.3
.bss 71628 72092 464 0.6
pump-controller-app LP_CC2652R7 (read/write) 183504 183968 464 0.3
.bss 71740 72204 464 0.6
shell LP_CC2652R7 (read/write) 156820 157284 464 0.3
.bss 76804 77268 464 0.6
cyw30739 light cyw930739m2evb_01 .bss 72064 72848 784 1.1
lock cyw930739m2evb_01 .bss 72240 73024 784 1.1
ota-requestor-no-progress-logging cyw930739m2evb_01 .bss 71248 72032 784 1.1
esp32 all-clusters-app c3devkit .dram0.bss 70640 71424 784 1.1
m5stack .dram0.bss 76152 76936 784 1.0
k32w light k32w061+release .bss 69756 70396 640 0.9
lock k32w061+release .bss 70204 70844 640 0.9
mbed lock-app CY8CPROTO_062_4343W+release .bss 212180 214692 2512 1.2
nrfconnect all-clusters-app nrf52840dk_nrf52840 bss 142862 143646 784 0.5
all-clusters-minimal-app nrf52840dk_nrf52840 bss 142098 142882 784 0.6
lighting-app nrf52840dk_nrf52840 bss 144441 145225 784 0.5
nrf52840dk_nrf52840+rpc bss 144886 145670 784 0.5
nrf52840dongle_nrf52840 bss 151672 152456 784 0.5
nrf5340dk_nrf5340_cpuapp bss 140812 141596 784 0.6
lock-app nrf52840dk_nrf52840 bss 134390 135174 784 0.6
nrf5340dk_nrf5340_cpuapp bss 130793 131577 784 0.6
pump-app nrf52840dk_nrf52840 bss 134336 135120 784 0.6
pump-controller-app nrf52840dk_nrf52840 bss 134131 134915 784 0.6
p6 all-clusters-app default .bss 147360 149872 2512 1.7
all-clusters-minimal-app default .bss 146640 149152 2512 1.7
light-app default .bss 138720 141232 2512 1.8
lock-app default .bss 138544 141056 2512 1.8
telink light-switch-app tlsr9518adk80d bss 71140 71952 812 1.1
lighting-app tlsr9518adk80d bss 71388 72172 784 1.1
Increases (31 builds for cc13x2_26x2, cyw30739, esp32, k32w, mbed, nrfconnect, p6, telink)
platform target config section 29451fb c4b4ca0 change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read/write) 191156 191620 464 0.2
.bss 74500 74964 464 0.6
all-clusters-minimal-app LP_CC2652R7 (read/write) 158060 158524 464 0.3
.bss 73788 74252 464 0.6
lock-ftd LP_CC2652R7 (read/write) 149620 150092 472 0.3
.bss 71500 71964 464 0.6
lock-mtd LP_CC2652R7 (read/write) 144632 145096 464 0.3
.bss 67236 67700 464 0.7
pump-app LP_CC2652R7 (read only) 673335 673343 8 0.0
(read/write) 169280 169736 456 0.3
.bss 71628 72092 464 0.6
.text 585068 585076 8 0.0
pump-controller-app LP_CC2652R7 (read/write) 183504 183968 464 0.3
.bss 71740 72204 464 0.6
shell LP_CC2652R7 (read/write) 156820 157284 464 0.3
.bss 76804 77268 464 0.6
cyw30739 light cyw930739m2evb_01 (read/write) 591738 592538 800 0.1
.app_xip_area 462636 462652 16 0.0
.bss 72064 72848 784 1.1
lock cyw930739m2evb_01 (read/write) 589130 589914 784 0.1
.bss 72240 73024 784 1.1
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 594262 595054 792 0.1
.app_xip_area 466032 466040 8 0.0
.bss 71248 72032 784 1.1
esp32 all-clusters-app c3devkit (read only) 1014134 1014148 14 0.0
(read/write) 1484882 1485666 784 0.1
.dram0.bss 70640 71424 784 1.1
.flash.text 1014134 1014148 14 0.0
m5stack (read/write) 486968 487752 784 0.2
.dram0.bss 76152 76936 784 1.0
k32w light k32w061+release (read/write) 661564 662204 640 0.1
.bss 69756 70396 640 0.9
lock k32w061+release (read/write) 723544 724200 656 0.1
.bss 70204 70844 640 0.9
.text 645540 645556 16 0.0
mbed lock-app CY8CPROTO_062_4343W+release .bss 212180 214692 2512 1.2
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1202387 1203187 800 0.1
bss 142862 143646 784 0.5
rodata 156372 156388 16 0.0
text 824228 824232 4 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1149735 1150519 784 0.1
bss 142098 142882 784 0.6
rodata 132704 132720 16 0.0
lighting-app nrf52840dk_nrf52840 (read/write) 1161535 1162319 784 0.1
bss 144441 145225 784 0.5
rodata 123160 123176 16 0.0
text 815060 815064 4 0.0
nrf52840dk_nrf52840+rpc (read/write) 1131607 1132519 912 0.1
bss 144886 145670 784 0.5
rodata 114704 114720 16 0.0
text 792788 792792 4 0.0
nrf52840dongle_nrf52840 (read/write) 1068387 1069283 896 0.1
bss 151672 152456 784 0.5
text 743460 743464 4 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 1065210 1066010 800 0.1
bss 140812 141596 784 0.6
rodata 115568 115584 16 0.0
text 727780 727784 4 0.0
lock-app nrf52840dk_nrf52840 (read/write) 1114503 1115431 928 0.1
bss 134390 135174 784 0.6
rodata 139912 139928 16 0.0
text 761448 761456 8 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 1018510 1019294 784 0.1
bss 130793 131577 784 0.6
rodata 132380 132396 16 0.0
text 674236 674240 4 0.0
pump-app nrf52840dk_nrf52840 (read/write) 1074487 1075287 800 0.1
bss 134336 135120 784 0.6
rodata 116544 116560 16 0.0
text 744764 744772 8 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 1062403 1063315 912 0.1
bss 134131 134915 784 0.6
rodata 113324 113340 16 0.0
text 736148 736152 4 0.0
p6 all-clusters-app default (read/write) 2555936 2555952 16 0.0
.bss 147360 149872 2512 1.7
.text 1514200 1514216 16 0.0
all-clusters-minimal-app default .bss 146640 149152 2512 1.7
light-app default (read/write) 2432536 2432552 16 0.0
.bss 138720 141232 2512 1.8
.text 1390800 1390816 16 0.0
lock-app default (read/write) 2453264 2453280 16 0.0
.bss 138544 141056 2512 1.8
.text 1411528 1411544 16 0.0
telink light-switch-app tlsr9518adk80d (read/write) 792208 793356 1148 0.1
bss 71140 71952 812 1.1
text 561074 561110 36 0.0
lighting-app tlsr9518adk80d (read/write) 811912 812704 792 0.1
bss 71388 72172 784 1.1
text 577532 577542 10 0.0
Decreases (1 build for cc13x2_26x2)
platform target config section 29451fb c4b4ca0 change % change
cc13x2_26x2 lock-ftd LP_CC2652R7 (read only) 692099 692091 -8 -0.0
.text 592148 592140 -8 -0.0
Full report (44 builds for cc13x2_26x2, cyw30739, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section 29451fb c4b4ca0 change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 660451 660451 0 0.0
(read/write) 191156 191620 464 0.2
.bss 74500 74964 464 0.6
.data 3356 3356 0 0.0
.rodata 87011 87011 0 0.0
.text 573128 573128 0 0.0
all-clusters-minimal-app LP_CC2652R7 (read only) 649351 649351 0 0.0
(read/write) 158060 158524 464 0.3
.bss 73788 74252 464 0.6
.data 3356 3356 0 0.0
.rodata 90623 90623 0 0.0
.text 558408 558408 0 0.0
lock-ftd LP_CC2652R7 (read only) 692099 692091 -8 -0.0
(read/write) 149620 150092 472 0.3
.bss 71500 71964 464 0.6
.data 3280 3280 0 0.0
.rodata 99467 99467 0 0.0
.text 592148 592140 -8 -0.0
lock-mtd LP_CC2652R7 (read only) 641515 641515 0 0.0
(read/write) 144632 145096 464 0.3
.bss 67236 67700 464 0.7
.data 3280 3280 0 0.0
.rodata 99355 99355 0 0.0
.text 541668 541668 0 0.0
pump-app LP_CC2652R7 (read only) 673335 673343 8 0.0
(read/write) 169280 169736 456 0.3
.bss 71628 72092 464 0.6
.data 3280 3280 0 0.0
.rodata 87783 87783 0 0.0
.text 585068 585076 8 0.0
pump-controller-app LP_CC2652R7 (read only) 659223 659223 0 0.0
(read/write) 183504 183968 464 0.3
.bss 71740 72204 464 0.6
.data 3276 3276 0 0.0
.rodata 83623 83623 0 0.0
.text 575120 575120 0 0.0
shell LP_CC2652R7 (read only) 690290 690290 0 0.0
(read/write) 156820 157284 464 0.3
.bss 76804 77268 464 0.6
.data 3360 3360 0 0.0
.rodata 109866 109866 0 0.0
.text 580112 580112 0 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 591738 592538 800 0.1
.app_xip_area 462636 462652 16 0.0
.bss 72064 72848 784 1.1
.data 716 716 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
lock cyw930739m2evb_01 (read/write) 589130 589914 784 0.1
.app_xip_area 459852 459852 0 0.0
.bss 72240 73024 784 1.1
.data 720 720 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 594262 595054 792 0.1
.app_xip_area 466032 466040 8 0.0
.bss 71248 72032 784 1.1
.data 660 660 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
esp32 all-clusters-app c3devkit (read only) 1014134 1014148 14 0.0
(read/write) 1484882 1485666 784 0.1
.dram0.bss 70640 71424 784 1.1
.dram0.data 14632 14632 0 0.0
.flash.rodata 214176 214176 0 0.0
.flash.text 1014134 1014148 14 0.0
.iram0.text 62902 62902 0 0.0
m5stack (read only) 1068475 1068475 0 0.0
(read/write) 486968 487752 784 0.2
.dram0.bss 76152 76936 784 1.0
.dram0.data 34144 34144 0 0.0
.flash.rodata 244676 244676 0 0.0
.flash.text 1063091 1063091 0 0.0
.iram0.text 123267 123267 0 0.0
k32w light k32w061+release (read/write) 661564 662204 640 0.1
.bss 69756 70396 640 0.9
.data 1992 1992 0 0.0
.text 584016 584016 0 0.0
lock k32w061+release (read/write) 723544 724200 656 0.1
.bss 70204 70844 640 0.9
.data 2000 2000 0 0.0
.text 645540 645556 16 0.0
linux all-clusters-app debug (read only) 2939145 2939145 0 0.0
(read/write) 177136 177136 0 0.0
.bss 84192 84192 0 0.0
.data 2048 2048 0 0.0
.data.rel.ro 84696 84696 0 0.0
.dynamic 608 608 0 0.0
.got 4536 4536 0 0.0
.init 27 27 0 0.0
.init_array 1032 1032 0 0.0
.rodata 261661 261661 0 0.0
.text 2500994 2500994 0 0.0
all-clusters-minimal-app debug (read only) 2792921 2792921 0 0.0
(read/write) 169040 169040 0 0.0
.bss 83520 83520 0 0.0
.data 2048 2048 0 0.0
.data.rel.ro 77336 77336 0 0.0
.dynamic 608 608 0 0.0
.got 4488 4488 0 0.0
.init 27 27 0 0.0
.init_array 1032 1032 0 0.0
.rodata 263261 263261 0 0.0
.text 2355346 2355346 0 0.0
bridge-app debug+rpc (read only) 2296905 2296905 0 0.0
(read/write) 147936 147936 0 0.0
.bss 71616 71616 0 0.0
.data 3792 3792 0 0.0
.data.rel.ro 66760 66760 0 0.0
.dynamic 608 608 0 0.0
.got 4400 4400 0 0.0
.init 27 27 0 0.0
.init_array 728 728 0 0.0
.rodata 196448 196448 0 0.0
.text 1939202 1939202 0 0.0
chip-tool debug (read only) 10165629 10165629 0 0.0
(read/write) 610600 610600 0 0.0
.bss 24416 24416 0 0.0
.data 1088 1088 0 0.0
.data.rel.ro 578792 578792 0 0.0
.dynamic 624 624 0 0.0
.got 5008 5008 0 0.0
.init 27 27 0 0.0
.init_array 640 640 0 0.0
.rodata 508629 508629 0 0.0
.text 8249013 8249013 0 0.0
chip-tool-no-interactive-ipv6only arm64 (read only) 9902644 9902644 0 0.0
(read/write) 675265 675265 0 0.0
.bss 42641 42641 0 0.0
.data 1152 1152 0 0.0
.data.rel.ro 614184 614184 0 0.0
.dynamic 528 528 0 0.0
.got 13472 13472 0 0.0
.init 24 24 0 0.0
.init_array 192 192 0 0.0
.rodata 471492 471492 0 0.0
.text 7892292 7892292 0 0.0
lighting-app debug+rpc (read only) 2533673 2533673 0 0.0
(read/write) 151928 151928 0 0.0
.bss 72064 72064 0 0.0
.data 2064 2064 0 0.0
.data.rel.ro 71912 71912 0 0.0
.dynamic 608 608 0 0.0
.got 4432 4432 0 0.0
.init 27 27 0 0.0
.init_array 816 816 0 0.0
.rodata 212200 212200 0 0.0
.text 2151634 2151634 0 0.0
lock-app debug (read only) 2466977 2466977 0 0.0
(read/write) 146672 146672 0 0.0
.bss 70496 70496 0 0.0
.data 1680 1680 0 0.0
.data.rel.ro 68632 68632 0 0.0
.dynamic 608 608 0 0.0
.got 4432 4432 0 0.0
.init 27 27 0 0.0
.init_array 776 776 0 0.0
.rodata 225928 225928 0 0.0
.text 2076610 2076610 0 0.0
ota-provider-app debug (read only) 2304817 2304817 0 0.0
(read/write) 140776 140776 0 0.0
.bss 70176 70176 0 0.0
.data 1912 1912 0 0.0
.data.rel.ro 62872 62872 0 0.0
.dynamic 608 608 0 0.0
.got 4496 4496 0 0.0
.init 27 27 0 0.0
.init_array 672 672 0 0.0
.rodata 202104 202104 0 0.0
.text 1940418 1940418 0 0.0
ota-requestor-app debug (read only) 2421921 2421921 0 0.0
(read/write) 147648 147648 0 0.0
.bss 72544 72544 0 0.0
.data 2200 2200 0 0.0
.data.rel.ro 67048 67048 0 0.0
.dynamic 608 608 0 0.0
.got 4488 4488 0 0.0
.init 27 27 0 0.0
.init_array 728 728 0 0.0
.rodata 205984 205984 0 0.0
.text 2045266 2045266 0 0.0
shell debug (read only) 2612633 2612633 0 0.0
(read/write) 196120 196120 0 0.0
.bss 111304 111304 0 0.0
.data 1232 1232 0 0.0
.data.rel.ro 77832 77832 0 0.0
.dynamic 608 608 0 0.0
.got 4168 4168 0 0.0
.init 27 27 0 0.0
.init_array 936 936 0 0.0
.rodata 231698 231698 0 0.0
.text 2221154 2221154 0 0.0
thermostat-no-ble arm64 (read only) 2579044 2579044 0 0.0
(read/write) 180673 180673 0 0.0
.bss 87905 87905 0 0.0
.data 1704 1704 0 0.0
.data.rel.ro 82952 82952 0 0.0
.dynamic 528 528 0 0.0
.got 5088 5088 0 0.0
.init 24 24 0 0.0
.init_array 400 400 0 0.0
.rodata 164724 164724 0 0.0
.text 2175104 2175104 0 0.0
tv-app debug (read only) 3079665 3079665 0 0.0
(read/write) 277864 277864 0 0.0
.bss 187720 187720 0 0.0
.data 4656 4656 0 0.0
.data.rel.ro 79048 79048 0 0.0
.dynamic 608 608 0 0.0
.got 4840 4840 0 0.0
.init 27 27 0 0.0
.init_array 952 952 0 0.0
.rodata 247808 247808 0 0.0
.text 2644946 2644946 0 0.0
tv-casting-app debug (read only) 5542289 5542289 0 0.0
(read/write) 184144 184144 0 0.0
.bss 72872 72872 0 0.0
.data 2448 2448 0 0.0
.data.rel.ro 102592 102592 0 0.0
.dynamic 608 608 0 0.0
.got 4712 4712 0 0.0
.init 27 27 0 0.0
.init_array 864 864 0 0.0
.rodata 341737 341737 0 0.0
.text 4924274 4924274 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2439536 2439536 0 0.0
.bss 212180 214692 2512 1.2
.data 5864 5864 0 0.0
.text 1402180 1402180 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1202387 1203187 800 0.1
bss 142862 143646 784 0.5
rodata 156372 156388 16 0.0
text 824228 824232 4 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1149735 1150519 784 0.1
bss 142098 142882 784 0.6
rodata 132704 132720 16 0.0
text 796020 796020 0 0.0
lighting-app nrf52840dk_nrf52840 (read/write) 1161535 1162319 784 0.1
bss 144441 145225 784 0.5
rodata 123160 123176 16 0.0
text 815060 815064 4 0.0
nrf52840dk_nrf52840+rpc (read/write) 1131607 1132519 912 0.1
bss 144886 145670 784 0.5
rodata 114704 114720 16 0.0
text 792788 792792 4 0.0
nrf52840dongle_nrf52840 (read/write) 1068387 1069283 896 0.1
bss 151672 152456 784 0.5
rodata 92236 92236 0 0.0
text 743460 743464 4 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 1065210 1066010 800 0.1
bss 140812 141596 784 0.6
rodata 115568 115584 16 0.0
text 727780 727784 4 0.0
lock-app nrf52840dk_nrf52840 (read/write) 1114503 1115431 928 0.1
bss 134390 135174 784 0.6
rodata 139912 139928 16 0.0
text 761448 761456 8 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 1018510 1019294 784 0.1
bss 130793 131577 784 0.6
rodata 132380 132396 16 0.0
text 674236 674240 4 0.0
pump-app nrf52840dk_nrf52840 (read/write) 1074487 1075287 800 0.1
bss 134336 135120 784 0.6
rodata 116544 116560 16 0.0
text 744764 744772 8 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 1062403 1063315 912 0.1
bss 134131 134915 784 0.6
rodata 113324 113340 16 0.0
text 736148 736152 4 0.0
p6 all-clusters-app default (read/write) 2555936 2555952 16 0.0
.bss 147360 149872 2512 1.7
.data 2776 2776 0 0.0
.text 1514200 1514216 16 0.0
all-clusters-minimal-app default (read/write) 2501800 2501800 0 0.0
.bss 146640 149152 2512 1.7
.data 2776 2776 0 0.0
.text 1460064 1460064 0 0.0
light-app default (read/write) 2432536 2432552 16 0.0
.bss 138720 141232 2512 1.8
.data 2592 2592 0 0.0
.text 1390800 1390816 16 0.0
lock-app default (read/write) 2453264 2453280 16 0.0
.bss 138544 141056 2512 1.8
.data 2600 2600 0 0.0
.text 1411528 1411544 16 0.0
telink light-switch-app tlsr9518adk80d (read/write) 792208 793356 1148 0.1
bss 71140 71952 812 1.1
noinit 40416 40416 0 0.0
text 561074 561110 36 0.0
lighting-app tlsr9518adk80d (read/write) 811912 812704 792 0.1
bss 71388 72172 784 1.1
noinit 40416 40416 0 0.0
text 577532 577542 10 0.0

woody-apple pushed a commit that referenced this pull request Jun 23, 2022
@markus-becker-tridonic-com
[xml] GenericSwitch: remove unrequired clusters: Binding, Groups, Sce…
f26da15 
…nes (#19881)

GenericSwitch only requires
```
ClusterName Client/Server Quality Conformance
Identify Server M
Switch Server M
FixedLabel Server desc
```
according to spec.

As requested in #19848 (comment).
@markus-becker-tridonic-com
Copy link
Contributor Author

Proposals how to fix the misspell error?

It's for keepSubscriptions in

2.  Subscribe to the `InitialPress` and `ShortRelease` event notifications:

        >>> switch subscribe-event initial-press 1 20 <node_id> 2 --is-urgent true --keepSubscriptions true`

which is in a code section.

Add to wordlist or has the code section be marked somehow?

@github-actions
Copy link

github-actions bot commented Jun 24, 2022 •
edited
Loading

PR #19848: Size comparison from 2d0c529 to a5c6bb1

Increases (4 builds for cc13x2_26x2, nrfconnect, telink)
platform target config section 2d0c529 a5c6bb1 change % change
cc13x2_26x2 lock-mtd LP_CC2652R7 (read only) 612931 612939 8 0.0
.text 537384 537392 8 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 text 815132 815136 4 0.0
pump-app nrf52840dk_nrf52840 text 744836 744840 4 0.0
telink light-switch-app tlsr9518adk80d (read/write) 793188 793544 356 0.0
bss 71924 71952 28 0.0
text 561224 561248 24 0.0
Decreases (1 build for k32w)
platform target config section 2d0c529 a5c6bb1 change % change
k32w light k32w061+release (read/write) 662824 662808 -16 -0.0
.text 584048 584032 -16 -0.0
Full report (38 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section 2d0c529 a5c6bb1 change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 660539 660539 0 0.0
(read/write) 192132 192132 0 0.0
.bss 75564 75564 0 0.0
.data 3352 3352 0 0.0
.rodata 87059 87059 0 0.0
.text 573168 573168 0 0.0
all-clusters-minimal-app LP_CC2652R7 (read only) 649431 649431 0 0.0
(read/write) 159120 159120 0 0.0
.bss 74852 74852 0 0.0
.data 3352 3352 0 0.0
.rodata 90671 90671 0 0.0
.text 558440 558440 0 0.0
lock-ftd LP_CC2652R7 (read only) 663523 663523 0 0.0
(read/write) 179292 179292 0 0.0
.bss 72596 72596 0 0.0
.data 3276 3276 0 0.0
.rodata 75179 75179 0 0.0
.text 587864 587864 0 0.0
lock-mtd LP_CC2652R7 (read only) 612931 612939 8 0.0
(read/write) 145724 145724 0 0.0
.bss 68332 68332 0 0.0
.data 3276 3276 0 0.0
.rodata 75059 75059 0 0.0
.text 537384 537392 8 0.0
pump-app LP_CC2652R7 (read only) 673439 673439 0 0.0
(read/write) 170240 170240 0 0.0
.bss 72692 72692 0 0.0
.data 3276 3276 0 0.0
.rodata 87831 87831 0 0.0
.text 585124 585124 0 0.0
pump-controller-app LP_CC2652R7 (read only) 659319 659319 0 0.0
(read/write) 184472 184472 0 0.0
.bss 72804 72804 0 0.0
.data 3272 3272 0 0.0
.rodata 83671 83671 0 0.0
.text 575168 575168 0 0.0
shell LP_CC2652R7 (read only) 690378 690378 0 0.0
(read/write) 157796 157796 0 0.0
.bss 77868 77868 0 0.0
.data 3356 3356 0 0.0
.rodata 109922 109922 0 0.0
.text 580144 580144 0 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 592610 592610 0 0.0
.app_xip_area 462732 462732 0 0.0
.bss 72848 72848 0 0.0
.data 712 712 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
lock cyw930739m2evb_01 (read/write) 594218 594218 0 0.0
.app_xip_area 464132 464132 0 0.0
.bss 73048 73048 0 0.0
.data 716 716 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 595238 595238 0 0.0
.app_xip_area 466232 466232 0 0.0
.bss 72032 72032 0 0.0
.data 656 656 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read/write) 1073348 1073348 0 0.0
.bss 134316 134316 0 0.0
.data 2044 2044 0 0.0
.text 936968 936968 0 0.0
BRD4161A+rpc (read/write) 1127436 1127436 0 0.0
.bss 151004 151004 0 0.0
.data 2256 2256 0 0.0
.text 974156 974156 0 0.0
BRD4161A+rs911x (read/write) 937376 937376 0 0.0
.bss 140088 140088 0 0.0
.data 2044 2044 0 0.0
.text 795220 795220 0 0.0
lock-app BRD4161A+wf200 (read/write) 1117580 1117580 0 0.0
.bss 140536 140536 0 0.0
.data 2056 2056 0 0.0
.text 974968 974968 0 0.0
window-app BRD4161A (read/write) 1058600 1058600 0 0.0
.bss 134388 134388 0 0.0
.data 2072 2072 0 0.0
.text 922120 922120 0 0.0
esp32 all-clusters-app c3devkit (read only) 1014322 1014322 0 0.0
(read/write) 1485698 1485698 0 0.0
.dram0.bss 71424 71424 0 0.0
.dram0.data 14624 14624 0 0.0
.flash.rodata 214224 214224 0 0.0
.flash.text 1014322 1014322 0 0.0
.iram0.text 62902 62902 0 0.0
m5stack (read only) 1068583 1068583 0 0.0
(read/write) 487800 487800 0 0.0
.dram0.bss 76936 76936 0 0.0
.dram0.data 34144 34144 0 0.0
.flash.rodata 244724 244724 0 0.0
.flash.text 1063199 1063199 0 0.0
.iram0.text 123267 123267 0 0.0
k32w light k32w061+release (read/write) 662824 662808 -16 -0.0
.bss 70988 70988 0 0.0
.data 1988 1988 0 0.0
.text 584048 584032 -16 -0.0
lock k32w061+release (read/write) 695120 695120 0 0.0
.bss 71460 71460 0 0.0
.data 2000 2000 0 0.0
.text 615860 615860 0 0.0
linux chip-tool-no-interactive-ipv6only arm64 (read only) 9903788 9903788 0 0.0
(read/write) 675249 675249 0 0.0
.bss 42641 42641 0 0.0
.data 1152 1152 0 0.0
.data.rel.ro 614176 614176 0 0.0
.dynamic 528 528 0 0.0
.got 13472 13472 0 0.0
.init 24 24 0 0.0
.init_array 192 192 0 0.0
.rodata 471484 471484 0 0.0
.text 7893428 7893428 0 0.0
thermostat-no-ble arm64 (read only) 2579164 2579164 0 0.0
(read/write) 180593 180593 0 0.0
.bss 87905 87905 0 0.0
.data 1696 1696 0 0.0
.data.rel.ro 82888 82888 0 0.0
.dynamic 528 528 0 0.0
.got 5088 5088 0 0.0
.init 24 24 0 0.0
.init_array 400 400 0 0.0
.rodata 164812 164812 0 0.0
.text 2175296 2175296 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2444192 2444192 0 0.0
.bss 214724 214724 0 0.0
.data 5872 5872 0 0.0
.text 1406836 1406836 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1203803 1203803 0 0.0
bss 144246 144246 0 0.0
rodata 156436 156436 0 0.0
text 824304 824304 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1151151 1151151 0 0.0
bss 143482 143482 0 0.0
rodata 132768 132768 0 0.0
text 796096 796096 0 0.0
lighting-app nrf52840dk_nrf52840 (read/write) 1163071 1163071 0 0.0
bss 145825 145825 0 0.0
rodata 123224 123224 0 0.0
text 815132 815136 4 0.0
nrf52840dk_nrf52840+rpc (read/write) 1133159 1133159 0 0.0
bss 146270 146270 0 0.0
rodata 114768 114768 0 0.0
text 792868 792868 0 0.0
nrf52840dongle_nrf52840 (read/write) 1069915 1069915 0 0.0
bss 153056 153056 0 0.0
rodata 92284 92284 0 0.0
text 743544 743544 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 1066730 1066730 0 0.0
bss 142196 142196 0 0.0
rodata 115632 115632 0 0.0
text 727860 727860 0 0.0
lock-app nrf52840dk_nrf52840 (read/write) 1120619 1120619 0 0.0
bss 135801 135801 0 0.0
rodata 140412 140412 0 0.0
text 765644 765644 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 1024610 1024610 0 0.0
bss 132204 132204 0 0.0
rodata 132880 132880 0 0.0
text 678428 678428 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 1076039 1076039 0 0.0
bss 135720 135720 0 0.0
rodata 116608 116608 0 0.0
text 744836 744840 4 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 1063943 1063943 0 0.0
bss 135515 135515 0 0.0
rodata 113392 113392 0 0.0
text 736224 736224 0 0.0
p6 all-clusters-app default (read/write) 2556024 2556024 0 0.0
.bss 149872 149872 0 0.0
.data 2768 2768 0 0.0
.text 1514288 1514288 0 0.0
all-clusters-minimal-app default (read/write) 2501872 2501872 0 0.0
.bss 149152 149152 0 0.0
.data 2768 2768 0 0.0
.text 1460136 1460136 0 0.0
light-app default (read/write) 2432632 2432632 0 0.0
.bss 141232 141232 0 0.0
.data 2584 2584 0 0.0
.text 1390896 1390896 0 0.0
lock-app default (read/write) 2458896 2458896 0 0.0
.bss 141080 141080 0 0.0
.data 2600 2600 0 0.0
.text 1417160 1417160 0 0.0
telink light-switch-app tlsr9518adk80d (read/write) 793188 793544 356 0.0
bss 71924 71952 28 0.0
noinit 40416 40416 0 0.0
text 561224 561248 24 0.0
lighting-app tlsr9518adk80d (read/write) 813500 813500 0 0.0
bss 72772 72772 0 0.0
noinit 40416 40416 0 0.0
text 577684 577684 0 0.0

@andy31415
Copy link
Contributor

Proposals how to fix the misspell error?

It's for keepSubscriptions in

2.  Subscribe to the `InitialPress` and `ShortRelease` event notifications:

        >>> switch subscribe-event initial-press 1 20 <node_id> 2 --is-urgent true --keepSubscriptions true`

which is in a code section.

Add to wordlist or has the code section be marked somehow?

It probably is missing backticks, so it thingks it is words. In the quote I seem to see a missing starting backtick

@andy31415 andy31415 merged commit 9d63f8b into project-chip:master Jun 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andy31415 andy31415 andy31415 approved these changes

@greg-fer greg-fer greg-fer approved these changes

@bzbarsky-apple bzbarsky-apple bzbarsky-apple approved these changes

@Damian-Nordic Damian-Nordic Damian-Nordic approved these changes

@anush-apple anush-apple Awaiting requested review from anush-apple

@arkq arkq Awaiting requested review from arkq

@Byungjoo-Lee Byungjoo-Lee Awaiting requested review from Byungjoo-Lee

@carol-apple carol-apple Awaiting requested review from carol-apple

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@emargolis emargolis Awaiting requested review from emargolis

@franck-apple franck-apple Awaiting requested review from franck-apple

@gjc13 gjc13 Awaiting requested review from gjc13

@harimau-qirex harimau-qirex Awaiting requested review from harimau-qirex

@hawk248 hawk248 Awaiting requested review from hawk248

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@isiu-apple isiu-apple Awaiting requested review from isiu-apple

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@jtung-apple jtung-apple Awaiting requested review from jtung-apple

@kpschoedel kpschoedel Awaiting requested review from kpschoedel

@lazarkov lazarkov Awaiting requested review from lazarkov

@LuDuda LuDuda Awaiting requested review from LuDuda

@mlepage-google mlepage-google Awaiting requested review from mlepage-google

@mrjerryjohns mrjerryjohns Awaiting requested review from mrjerryjohns

@msandstedt msandstedt Awaiting requested review from msandstedt

@mspang mspang Awaiting requested review from mspang

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

@sagar-apple sagar-apple Awaiting requested review from sagar-apple

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tcarmelveilleux tcarmelveilleux Awaiting requested review from tcarmelveilleux

@tecimovic tecimovic Awaiting requested review from tecimovic

@vijs vijs Awaiting requested review from vijs

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wbschiller wbschiller Awaiting requested review from wbschiller

@woody-apple woody-apple Awaiting requested review from woody-apple

@xylophone21 xylophone21 Awaiting requested review from xylophone21

@yunhanw-google yunhanw-google Awaiting requested review from yunhanw-google

Assignees
No one assigned
Labels
examples github review - approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@markus-becker-tridonic-com @greg-fer @andy31415 @bzbarsky-apple @Damian-Nordic @restyled-commits